-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the Lightstep Metrics SDK #196
Conversation
Add the internal/viewstate package for review LS-29753
…launcher-go into alt_metrics_sdk/provider_review
Add the MeterProvider and related packages for review LS-29752
…launcher-go into alt_metrics_sdk/review_internalstate
…launcher-go into jmacd/review_expohisto
…uncher-go into jmacd/review_expohisto
❤️ Co-authored-by: Nathan Vērzemnieks <njvrzm@gmail.com>
Document the alternate metrics SDK, usability fixes
More documentation for Lightstep metrics SDK
…_metrics_sdk/reviewed
I am officially stuck (from my machine):
or (from CI)_
|
After disabling the linters, I've found some flakey test failures. |
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 90.72% 94.65% +3.92%
==========================================
Files 7 62 +55
Lines 485 3234 +2749
==========================================
+ Hits 440 3061 +2621
- Misses 26 131 +105
- Partials 19 42 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooo very excited!! Thank you so much!
Description: This merges the work covered in PRs:
#171
#172
#173
#174
#175
#183
#184
#185
#190
#191
#195
Link to tracking Issue: LS-29760
Testing: The SDK is completely unit-tested. Manual integration testing with lightstep has been done.
Thanks: Thanks to @MadVikingGod for substantial early feedback on the design of the Lightstep metrics SDK. Thanks to @jaronoff97 @njvrzm @paivagustavo @codeboten for reivews.