Add the OTLP and test exporters for review LS-29755 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/sethvargo/go-envconfig](https://github.com/sethvargo/go-envconfig) from 0.6.0 to 0.6.1. - [Release notes](https://github.com/sethvargo/go-envconfig/releases) - [Commits](sethvargo/go-envconfig@v0.6.0...v0.6.1) --- updated-dependencies: - dependency-name: github.com/sethvargo/go-envconfig dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/sethvargo/go-envconfig](https://github.com/sethvargo/go-envconfig) from 0.6.1 to 0.6.2. - [Release notes](https://github.com/sethvargo/go-envconfig/releases) - [Commits](sethvargo/go-envconfig@v0.6.1...v0.6.2) --- updated-dependencies: - dependency-name: github.com/sethvargo/go-envconfig dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…launcher-go into alt_metrics_sdk/exporter_review
…_metrics_sdk/exporter_review
njvrzm
approved these changes
Jun 9, 2022
lightstep/sdk/metric/exporters/otlp/internal/metrictransform/attribute.go
Outdated
Show resolved
Hide resolved
lightstep/sdk/metric/exporters/otlp/internal/metrictransform/resource.go
Outdated
Show resolved
Hide resolved
paivagustavo
approved these changes
Jun 9, 2022
lightstep/sdk/metric/exporters/otlp/internal/metrictransform/attribute_test.go
Outdated
Show resolved
Hide resolved
|
Restored full test coverage here. I will now merge this. The lightstep/sdk/metric directory is finished, what's left to do is specific to otel-launcher-go in the ./pipelines directory and thinking about how to release this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The exporters package contains the OTLP Exporter. MUCH of this package is copied from the upstream SDK. In the internal/ subpackage, only the metrictransform package is new, the other stuff is copied. The only new functionality has to do with OTEL_EXPORTER_OTLP_METRIC_TEMPORALITY_PREFERENCE support.
Link to tracking Issue:
LS-29760 describes the overall goal; this is one part.
Testing:
End-to-end testing was done. The alt_metrics_sdk/development branch has a assembled copy of this code. Depends on various Lightstep-side PRs merging to see the exponential histograms work.