REST API responses missing falsey values

[wbobeirne]

Background

The /v1/channels GET endpoint comes back with {} if you have no channels. This is inconsistent with the gRPC API which comes back with { "channels": [] }.

Your environment

• version of lnd 0.5.0-beta
• which operating system (uname -a on *Nix) - macOS
• version of btcd, bitcoind, or other backend - btcd simnet

Steps to reproduce

Hit the GET /v1/channels endpoint

Expected behaviour

{ "channels": [] }

Actual behaviour

{}

[wbobeirne]

I noticed this as well with the balance API when you have zero balance (for v1/balance/blockchain and v1/balance/channels) so I assume the api is just stripping out all falsey values or empty arrays. I'm going to change the issue title to reflect that larger scope.

[Roasbeef]

Yep, it's just the API removing "false-y" values. If the key isn't there, then you can assume it simply isn't present. In one case, there are no channels at all, in the other case, it looks like there have been in the DB in the past, so a slice gets created, but not fully populated.

[cfromknecht]

relevant? grpc-ecosystem/grpc-gateway#233 (comment)

looks like work on this in being done for 2.0 grpc-ecosystem/grpc-gateway#546