close_type missing from REST API /v1/channels/closed response

[kaipila]

Background

I noticed the close_type parameter is missing from the REST API /v1/channels/ response for some reason. The documentation at /api.lightning.community/rest/ says that it should be there but it is not

lncli shows me this field and it uses the GRPC API so I am guessing there is something wrong with the REST API implementation.

Your environment

0.7.1-beta commit=v0.7.1-beta-rc1
Darwin Anttis-MBP 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64

Steps to reproduce

curl -X GET https://localhost:8081/v1/channels/closed
lncli closedchannels

And compare the results.

Expected behaviour

I would expect the close_type field be available in both API's.

Actual behaviour

REST API does not have it.

[wpaulino]

Related to #2087.

At the moment with REST if the response doesn't include one of its fields, then you can assume it's the default value. In this case the default value for close_type is COOPERATIVE_CLOSE (https://api.lightning.community/rest/index.html#channelclosesummaryclosuretype).