Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API /v1/pool/orders state field when ORDER_SUBMITTED is missing #208

Closed
mutatrum opened this issue Jan 25, 2021 · 3 comments · Fixed by #210
Closed

REST API /v1/pool/orders state field when ORDER_SUBMITTED is missing #208

mutatrum opened this issue Jan 25, 2021 · 3 comments · Fixed by #210

Comments

@mutatrum
Copy link

The state field for newly submitted orders is missing. Through the pool cli, these are shown as ORDER_SUBMITTED.

Secondary: the default for the rest call is active_only = false, for the pool clli, the default is true.

@mutatrum
Copy link
Author

Scrubbed output of a newly created order, without state field:

    details: {
      trader_key: 'xxxxx',
      rate_fixed: ####,
      amt: '#####',
      max_batch_fee_rate_sat_per_kw: '####',
      order_nonce: xxxxx',
      units: ##,
      units_unfulfilled: ##,
      reserved_value_sat: '###',
      creation_timestamp_ns: '########',
      min_units_match: #
    },
    lease_duration_blocks: 2016,
    version: 2
  },

Cancelled, executed and partially_executed orders do have the state field.

@wpaulino
Copy link
Contributor

Seems similar to lightningnetwork/lnd#2087, ORDER_SUBMITTED is the default value.

@mutatrum
Copy link
Author

ORDER_SUBMITTED has enum value of 0, I saw that indeed. Looks similar to mentioned issue. I can't easily verify this with the other 0 valued enums.

guggero added a commit to guggero/pool that referenced this issue Jan 26, 2021
Fixes lightninglabs#208 by always rendering the default values in a JSON response,
even if they are "falsey" in the RPC message.
guggero added a commit to guggero/pool that referenced this issue Jan 28, 2021
Fixes lightninglabs#208 by always rendering the default values in a JSON response,
even if they are "falsey" in the RPC message.
guggero added a commit to guggero/pool that referenced this issue Jan 28, 2021
Fixes lightninglabs#208 by always rendering the default values in a JSON response,
even if they are "falsey" in the RPC message.
guggero added a commit to guggero/pool that referenced this issue Jan 29, 2021
Fixes lightninglabs#208 by always rendering the default values in a JSON response,
even if they are "falsey" in the RPC message.
guggero added a commit to guggero/pool that referenced this issue Feb 2, 2021
Fixes lightninglabs#208 by always rendering the default values in a JSON response,
even if they are "falsey" in the RPC message.
positiveblue pushed a commit to positiveblue/pool that referenced this issue Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants