Don't truncate actual characters out of snippets #242
Conversation
tests/src/test/scala/com/lightbend/paradox/markdown/SnipDirectiveSpec.scala
Show resolved
Hide resolved
|
Relates to #228 |
| |<pre class="prettyprint"> | ||
| |<code class="language-scala"> | ||
| |object AnotherIndentedExample { | ||
| |def rendered(): Unit = { |
There was a problem hiding this comment.
@ennru Do you mean this, that the inner indentation is lost here?
There was a problem hiding this comment.
Yeah, I think best would be to base indentation off the indentation of the following non-empty line or something like that rather? But I don't think it is possible to get a solution that works for all use-cases without having some extra flags for deciding if to keep indent level or drop (the imports + main method contents vs "normal" code
There was a problem hiding this comment.
Not sure I want to jump into trying to fix that here though, I just want to make sure no actual characters except whitespace is truncated for now.
There was a problem hiding this comment.
Yes, just a note on what this gives. Not cutting text is the best solution for now. @2m and I discussed some interplay of code formatters and this snippet cutting, but we didn't have this case.
This rolls back the snippet indentation logic introduced by #201. But has special handling for `import` lines, so that they become aligned with the left-most code in other snippets with the same label. Relates to: akka/akka#25564 #242
Fixes #241