Fixup multisnippet indent #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
approved these changes
Jun 15, 2018
|
Nice one |
|
@2m is there a usecase for this which we can review when fixing up the overindentation issue? |
|
The newly added test-case exercises that code: https://github.com/lightbend/paradox/pull/201/files#diff-8d79ec1d035f6c1d99a65339227c81a2R85 Also any multi-snippet that has different indentation, like here. The imports and the code have different indentation, but the rendered result has same and correct indentation. |
This was referenced Sep 4, 2018
Closed
ennru
added a commit
that referenced
this pull request
Sep 11, 2018
This rolls back the snippet indentation logic introduced by #201. But has special handling for `import` lines, so that they become aligned with the left-most code in other snippets with the same label. Relates to: akka/akka#25564 #242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds indent tracking at the start of the block. This indent is then removed for every line of the block. The result is evenly indented multi-snippets even when the original code has different indentations for different snippets.