Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gossipsub): deprecate Config::idle_timeout #4648

Merged
merged 6 commits into from
Oct 15, 2023
Merged

feat(gossipsub): deprecate Config::idle_timeout #4648

merged 6 commits into from
Oct 15, 2023

Conversation

leonzchang
Copy link
Contributor

@leonzchang leonzchang commented Oct 14, 2023 •
edited by thomaseizinger
Loading

Description

Deprecate the Config::idle_timeout function in preparation for removing the KeepAlive::Until entirely.

Related: #3844.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang marked this pull request as ready for review October 14, 2023 15:36
@leonzchang leonzchang mentioned this pull request Oct 14, 2023
Merged
4 tasks
thomaseizinger
thomaseizinger approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@thomaseizinger
Copy link
Contributor

It seems like you'll need to place a few select #[allow(deprecated)] in the code for CI to pass!

@thomaseizinger thomaseizinger mentioned this pull request Oct 14, 2023
Closed
@leonzchang
Copy link
Contributor Author

It seems like you'll need to place a few select #[allow(deprecated)] in the code for CI to pass!

Thanks, added 7ff11f3

@mergify mergify bot merged commit 15ad4ea into libp2p:master Oct 15, 2023
@thomaseizinger thomaseizinger mentioned this pull request Oct 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonzchang @thomaseizinger