Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gossipsub): remove KeepAlive::Until #4642

Merged
merged 11 commits into from
Oct 20, 2023
Merged

feat(gossipsub): remove KeepAlive::Until #4642

merged 11 commits into from
Oct 20, 2023

Conversation

leonzchang
Copy link
Contributor

@leonzchang leonzchang commented Oct 13, 2023 •
edited by thomaseizinger
Loading

Description

Related: #3844.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
Copy link
Member

mxinden commented Oct 13, 2023

Cool! Let us know once this is ready for review.

Generally in favor of removing the idle timeout from libp2p-gossipsub in favor of the libp2p-swarm with_idle_connection_timeout.

@leonzchang leonzchang changed the title refactor(libp2p-gossipsub): remove KeepAlive::Until usage from libp2p-gossipsub refactor(gossipsub): remove KeepAlive::Until usage from gossipsub Oct 13, 2023
@leonzchang
Copy link
Contributor Author

@mxinden I would be deeply grateful for your feedback

thomaseizinger
thomaseizinger reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the patch! One small point, otherwise LGTM!

protocols/gossipsub/src/config.rs Show resolved Hide resolved
protocols/gossipsub/Cargo.toml Outdated Show resolved Hide resolved
protocols/gossipsub/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger mentioned this pull request Oct 13, 2023
Closed
@thomaseizinger thomaseizinger changed the title refactor(gossipsub): remove KeepAlive::Until usage from gossipsub feat(gossipsub): remove KeepAlive::Until usage from gossipsub Oct 13, 2023
@thomaseizinger thomaseizinger changed the title feat(gossipsub): remove KeepAlive::Until usage from gossipsub feat(gossipsub): remove KeepAlive::Until usage Oct 13, 2023
@thomaseizinger thomaseizinger changed the title feat(gossipsub): remove KeepAlive::Until usage feat(gossipsub): remove KeepAlive::Until Oct 13, 2023
@leonzchang
Copy link
Contributor Author

If this PR is okay, I'll move on to the rest protocols.

thomaseizinger
thomaseizinger previously approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you for the contributions! :)

@thomaseizinger
Copy link
Contributor

FYI: We set all PRs that are queued for the next breaking change to draft to avoid accidentally merging them.

@thomaseizinger thomaseizinger marked this pull request as draft October 14, 2023 21:08
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Oct 14, 2023
@thomaseizinger
Copy link
Contributor

If this PR is okay, I'll move on to the rest protocols.

Looks good to me, thank you!

@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger marked this pull request as ready for review October 20, 2023 01:13
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏

@mergify mergify bot dismissed thomaseizinger’s stale review October 20, 2023 01:31

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏

@mergify mergify bot merged commit fafa6bc into libp2p:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.
3 participants
@leonzchang @mxinden @thomaseizinger