Initial implementation of the libp2p introspection server #1
Conversation
TODO
|
There was a problem hiding this comment.
Would like to see what the fetch logic ends up looking like after integrating my review comments from libp2p/go-libp2p-core#107. Besides that, nothing controversial here so far.
|
@raulk The new fetch logic is up. |
|
@raulk Please can you explain how to determine |
| sids = append(sids, introspect.StreamID(s)) | ||
| } | ||
|
|
||
| sl, err := d.tree.Stream(introspect.StreamQueryParams{introspect.QueryOutputFull, sids}) |
There was a problem hiding this comment.
This is fine for now, but we could further optimise this by collecting all stream IDs from all connections, and fetching them all at once, then merging them into the appropriate connections. Could you file an issue to optimise this?
|
|
||
| // start server | ||
| serverInstance := http.Server{ | ||
| // TODO Need a better strategy to select an address |
There was a problem hiding this comment.
Let's make sure this doesn't fall off the radar by opening an issue.
| type DefaultIntrospector struct { | ||
| treeMu sync.RWMutex | ||
| tree *introspect.DataProviders | ||
| listenAddr []string |
| } | ||
| } | ||
|
|
||
| func wsUpgrader(introspector introspect.Introspector) http.HandlerFunc { |
| } | ||
|
|
||
| // send the response | ||
| wsConn.SetWriteDeadline(time.Now().Add(10 * time.Second)) |
| github.com/gorilla/websocket v1.4.1 | ||
| github.com/imdario/mergo v0.3.8 | ||
| github.com/ipfs/go-log v1.0.1 | ||
| github.com/libp2p/go-libp2p-core v0.3.1-0.20200206170018-fbc69c15df4c |
There was a problem hiding this comment.
This import was missing. It's locked to a commit, but it's fine for now.
For libp2p/go-libp2p#775
This is the first draft of the introspection server.