This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Introspection types for core #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2020
1d7548b to
50ad563
Compare
raulk
reviewed
Jan 23, 2020
introspection/providers_tree.go
Outdated
| // Enums. | ||
| type ( | ||
| // StreamListQueryType is an Enum to represent the types of queries that can be made when looking up streams | ||
| StreamListQueryType int |
There was a problem hiding this comment.
I think we can generalise this type and name it QueryOutput, with two concrete enum values: QueryOutputList, QueryOutputFull.
There was a problem hiding this comment.
I've come up with QueryOutputTypeFull & QueryOutputTypeIds which determine whether we want to resolve an output object completely or just fetch it's Ids.
|
@raulk The first round of review has been addressed. |
raulk
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For libp2p/go-libp2p#775
All the introspection types/protocols required to be in core.