introspection: review comments. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
requested changes
Feb 3, 2020
| } | ||
|
|
||
| type ConnectionQueryParams struct { | ||
| Output QueryOutput |
There was a problem hiding this comment.
@raulk This struct is not enough to represent all the params of a connection query.
How would you specify whether you want ONLY Ids vs full objects for the Streams in the connection ? The Output field here specifies whether we want full connection objects vs connection Ids. But, what about the streams ?
| StreamOutputType QueryOutputType | ||
| ConnIDs []ConnID | ||
| type StreamQueryParams struct { | ||
| Output QueryOutput |
There was a problem hiding this comment.
How would you specify whether you want just the Connection Ids or the full connection objects in the output ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introspect.Introspectormethods.