Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade LWJGL 3 to 3.3.3 #7555

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Downgrade LWJGL 3 to 3.3.3 #7555

merged 1 commit into from
Jan 1, 2025

Conversation

obigu
Copy link
Contributor

@obigu obigu commented Dec 31, 2024

Given the AV false positives of 3.3.4 (#7552) and some on 3.3.5 and the log spamming issue occurring on 3.3.5 (kcat/openal-soft#1086) that won't be fixed until 3.3.6 best approach is to downgrade to stable 3.3.3 for libGDX 1.13.1 release until these problems are fixed.

RISC-V natives won't be shipped with libGDX, if there's any RISC-V user they can upgrade lwjgl and add the dependencies on their end.

@obigu obigu added this to the 1.13.1 milestone Dec 31, 2024
Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me. The RISCV natives probably shouldn't be shipped anyway unless libGDX can also run on that arch; otherwise, they're just dead weight. I have no idea what RISCV devices even exist in 2024 2025...

@Frosty-J
Copy link
Contributor

Frosty-J commented Jan 1, 2025

The RISCV natives probably shouldn't be shipped anyway unless libGDX can also run on that arch

It does.

libgdx/CHANGES

Line 55 in f68ded4

- Architecture support: Support for Linux RISC-V has been added. The gdx-xxx-natives-desktop.jar files now also contain native libraries for this architecture.
libgdx/gdx-jnigen#48

@obigu obigu merged commit 35afa79 into libgdx:master Jan 1, 2025
2 checks passed
@obigu obigu deleted the lwjgl3downgrade branch January 1, 2025 14:04
@0XDE57 0XDE57 mentioned this pull request Jan 1, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants