feat: Introduce RISC-V support #48

SimonIT · 2023-09-30T22:38:09Z

Not tested yet, love to hear some comments

EDIT: Works flawless

Frosty-J · 2023-09-30T23:34:14Z

Looks alright, though I won't be able to test it with the hardware I currently have. I might get a RISC-V SBC at some point, though don't see much reason to get one over ARM at this time.

I wouldn't worry about 32-bit RISC-V (but worth supporting if it's trivial to). The is64Bit boolean isn't very ready for 128-bit RISC-V, but I don't know if any 128-bit hardware even exists yet (it's in the specification).

While I think about it, there's a lot of natives downloaded and bundled into libGDX game JARs (x86, x64, arm32, arm64... potentially RISC-V in future – Windows, macOS, Linux) – maybe an opt-in solution could be realised for that? E.g. if someone is only interested in 64-bit Windows (not unheard of for Steam titles), don't bother with the rest. But this is probably a discussion for elsewhere, and not the most important thing in the world.

SimonIT · 2023-10-02T14:47:00Z

It works🎉

➜  gdx-jnigen git:(riscv) ✗ ./gradlew build
> Task :gdx-jnigen:compileJava UP-TO-DATE
> Task :gdx-jnigen:processResources UP-TO-DATE
> Task :gdx-jnigen:classes UP-TO-DATE
> Task :gdx-jnigen:jar UP-TO-DATE
> Task :gdx-jnigen:javadoc UP-TO-DATE
> Task :gdx-jnigen:javadocJar UP-TO-DATE
> Task :gdx-jnigen:sourcesJar UP-TO-DATE
> Task :gdx-jnigen:assemble UP-TO-DATE
> Task :gdx-jnigen-loader:compileJava UP-TO-DATE
> Task :gdx-jnigen:compileTestJava UP-TO-DATE
> Task :gdx-jnigen:processTestResources NO-SOURCE
> Task :gdx-jnigen:testClasses UP-TO-DATE
> Task :gdx-jnigen-loader:processResources NO-SOURCE
> Task :gdx-jnigen-loader:classes UP-TO-DATE
> Task :gdx-jnigen-loader:jar UP-TO-DATE
> Task :gdx-jnigen:test

boolean: true
byte: 1
char: �
short: 3
int: 4
long: %
float: 6.000000
double: 0
byteBuffer: 8
bool[0]: false
char[0]:
short[0]: 10
int[0]: 11
long[0]: %
float[0]: 13.000000
double[0]: 14.000000
string: Hurray fuck this nuts

> Task :gdx-jnigen:check
> Task :gdx-jnigen:build
> Task :gdx-jnigen-gradle:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :gdx-jnigen-gradle:processResources
> Task :gdx-jnigen-gradle:classes
> Task :gdx-jnigen-gradle:jar
> Task :gdx-jnigen-gradle:javadoc
> Task :gdx-jnigen-gradle:javadocJar
> Task :gdx-jnigen-gradle:sourcesJar
> Task :gdx-jnigen-gradle:assemble
> Task :gdx-jnigen-gradle:compileTestJava NO-SOURCE
> Task :gdx-jnigen-gradle:processTestResources NO-SOURCE
> Task :gdx-jnigen-gradle:testClasses UP-TO-DATE
> Task :gdx-jnigen-gradle:test NO-SOURCE
> Task :gdx-jnigen-gradle:check UP-TO-DATE
> Task :gdx-jnigen-gradle:build
> Task :gdx-jnigen-loader:javadoc
> Task :gdx-jnigen-loader:javadocJar
> Task :gdx-jnigen-loader:sourcesJar
> Task :gdx-jnigen-loader:assemble
> Task :gdx-jnigen-loader:compileTestJava NO-SOURCE
> Task :gdx-jnigen-loader:processTestResources NO-SOURCE
> Task :gdx-jnigen-loader:testClasses UP-TO-DATE
> Task :gdx-jnigen-loader:test NO-SOURCE
> Task :gdx-jnigen-loader:check UP-TO-DATE
> Task :gdx-jnigen-loader:build

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 1h 37m 19s
19 actionable tasks: 10 executed, 9 up-to-date

But the gradle build is freaking slow on the board... I guess the jdk is not well optimized for riscv or something.

I agree with you about choosing the architecture. Maybe it's something for the gdx-setup app? Or do we add Gradle tasks that generate one jar per architecture?

Berstanio · 2023-10-02T14:59:04Z

I agree with you about choosing the architecture. Maybe it's something for the gdx-setup app? Or do we add Gradle tasks that generate one jar per architecture?

I'm not sure, whether this isn't a bit bloated. We already have 6 jars produced with natives, if now desktop gets split up too we end up with like around 23 jars if we split on os and arch. Only splitting on arch would be around 11 jars, which is still a lot in my opinion.

PokeMMO · 2023-10-12T09:04:35Z

At first glance, we should consider replacing isARM and isRISCV with a more generic arch enum (or some other extendable argument)

While there, it might also make sense to turn is64 into an enum of potential bitness.

I think this should all be able to do be done while ensuring backwards compatibility too.

SimonIT · 2023-10-15T13:01:43Z

Done, do you think we should deprecate methods with boolean is64Bit, boolean isARM?
Those constants are then pretty useless:

	public static final boolean x32 = false;
	public static final boolean x64 = true;
	public static final boolean ARM = true;
	public static final boolean RISCV = true;

Should we also change the shared library loader?
I also think the extra handling for android and ios is a bit ugly.

PokeMMO · 2023-10-15T16:36:17Z

Done, do you think we should deprecate methods with boolean is64Bit, boolean isARM?

Yeah, the legacy methods should be marked as deprecated.

Those constants are then pretty useless:

I was assuming we could replace them with references to the enums in a backwards compatible manner, but I haven't experimented to check if that's actually possible.

Should we also change the shared library loader?

I think so, but doing so would be very breaking, and might be worthwhile keeping the old ones as accurate as we can.

SimonIT · 2023-10-15T18:09:49Z

Done, except for the shared library loader. The reason is that I'm not sure where to put the enums because, in the current position, it's not able to access them

SimonIT · 2023-11-01T19:59:33Z

Do you have an idea? Should we move the enum to SharedLibraryLoader? Or do we want to leave it as it is?

PokeMMO · 2023-11-05T18:23:44Z

I think move it to SharedLibraryLoader, and make a new static field for the arch. Also leave the old isARM, isRISCV, is64Bit but mark them as deprecated.

SimonIT · 2023-11-07T19:18:03Z

Everything is moved

Berstanio · 2023-11-08T09:22:48Z

gdx-jnigen/src/main/java/com/badlogic/gdx/jnigen/BuildTarget.java

-	public BuildTarget (BuildTarget.TargetOs targetType, boolean is64Bit, String[] cIncludes, String[] cExcludes,
-		String[] cppIncludes, String[] cppExcludes, String[] headerDirs, String compilerPrefix, String cFlags, String cppFlags,
-		String linkerFlags) {
+	public BuildTarget(Os targetType, Architecture.Bitness bitness, String[] cIncludes, String[] cExcludes, String[] cppIncludes, String[] cppExcludes, String[] headerDirs, String compilerPrefix, String cFlags, String cppFlags, String linkerFlags) {


Might make sense to pass here also just the architecture, instead of setting it in newDefaultTarget?

I have no real opinion on this

gdx-jnigen-loader/src/main/java/com/badlogic/gdx/utils/SharedLibraryLoader.java

gdx-jnigen-gradle/src/main/java/com/badlogic/gdx/jnigen/gradle/JnigenExtension.java

PokeMMO · 2023-11-08T21:17:04Z

Merged!

Next step should be PR with -SNAPSHOT to libgdx to triple check before we make a new release.

feat: Introduce RISC-V support

f1de6ac

SimonIT marked this pull request as ready for review October 2, 2023 14:47

SimonIT added the hacktoberfest-accepted label Oct 2, 2023

SimonIT requested a review from PokeMMO October 4, 2023 22:09

fix: typos

c496384

SimonIT added 2 commits October 12, 2023 21:31

feat: Use enum for architecture and bitness

8e72b0f

fix: Better bitness handling in build target

691c6a9

SimonIT added 2 commits October 15, 2023 19:41

fix: Deprecate old methods

fb60370

feat: Provide constants for architecture and bitness in gradle

124bedb

SimonIT added 2 commits October 23, 2023 12:39

Merge branch 'master' into riscv

b3fb59b

fix: Deprecate also get

9d0e321

feat: Move enums to loader

875160c

Berstanio reviewed Nov 8, 2023

View reviewed changes

SimonIT added 2 commits November 8, 2023 20:38

fix: Add missing add method to JnigenExtension

49f1e8a

doc: Add replacement information for *is*-fields in SharedLibraryLoader

2dfd0f8

PokeMMO merged commit e6873a8 into libgdx:master Nov 8, 2023

SimonIT deleted the riscv branch November 8, 2023 21:23

Frosty-J mentioned this pull request Jan 1, 2025

Downgrade LWJGL 3 to 3.3.3 libgdx/libgdx#7555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Introduce RISC-V support #48

feat: Introduce RISC-V support #48

SimonIT commented Sep 30, 2023 •

edited

Loading

Frosty-J commented Sep 30, 2023

SimonIT commented Oct 2, 2023 •

edited

Loading

Berstanio commented Oct 2, 2023

PokeMMO commented Oct 12, 2023

SimonIT commented Oct 15, 2023 •

edited

Loading

PokeMMO commented Oct 15, 2023

SimonIT commented Oct 15, 2023

SimonIT commented Nov 1, 2023

PokeMMO commented Nov 5, 2023

SimonIT commented Nov 7, 2023 •

edited

Loading

Berstanio Nov 8, 2023

SimonIT Nov 8, 2023

PokeMMO commented Nov 8, 2023

feat: Introduce RISC-V support #48

feat: Introduce RISC-V support #48

Conversation

SimonIT commented Sep 30, 2023 • edited Loading

Frosty-J commented Sep 30, 2023

SimonIT commented Oct 2, 2023 • edited Loading

Berstanio commented Oct 2, 2023

PokeMMO commented Oct 12, 2023

SimonIT commented Oct 15, 2023 • edited Loading

PokeMMO commented Oct 15, 2023

SimonIT commented Oct 15, 2023

SimonIT commented Nov 1, 2023

PokeMMO commented Nov 5, 2023

SimonIT commented Nov 7, 2023 • edited Loading

Berstanio Nov 8, 2023

Choose a reason for hiding this comment

SimonIT Nov 8, 2023

Choose a reason for hiding this comment

PokeMMO commented Nov 8, 2023

SimonIT commented Sep 30, 2023 •

edited

Loading

SimonIT commented Oct 2, 2023 •

edited

Loading

SimonIT commented Oct 15, 2023 •

edited

Loading

SimonIT commented Nov 7, 2023 •

edited

Loading