Implement stop request in federated execution of TypeScript #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of using greasted TAG.
…y handled by the default case of the switch statement. Update comments.
…pdating only the tag or the state.
…re is no event at (0, 0), by moving _iterationComplete() into the if statement, `if (nextEvent)`. This issue was discovered when running the newly added federated test, DistributedStop.lf, while working on implementation of stop request messages in TypeScrip federated execution.
lhstrh
previously requested changes
Jul 21, 2022
… in the comments.
|
@ByeongGil-Jun, I granted you write access to the lingua-franca repo (https://github.com/lf-lang/lingua-franca/). From now on, you should be able to create branches and edit wiki pages here: https://github.com/lf-lang/lingua-franca/wiki |
(However, lingua-franca-ref.txt must be updated before merging.) # Conflicts: # lingua-franca-ref.txt # src/core/federation.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #101
Relevant LF PR: lf-lang/lingua-franca#1302
Add a logic for sending and propagating MSG_TYPE_STOP_REQUEST and MSG_TYPE_STOP_REQUEST_REPLY and receive MSG_TYPE_STOP_REQUEST_GRANTED
Discussion is needed to determine whether freeze federates or not.
Some function in reactor.ts is added and modified like getStartTag() and getStartTime() etc.