Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in TypeScript for requesting stop in federated execution #1302

Merged
merged 32 commits into from
Aug 2, 2022

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Jul 20, 2022

Relevant issue: lf-lang/reactor-ts#101

Relevant reactor-ts PR: lf-lang/reactor-ts#111

@hokeun hokeun marked this pull request as ready for review July 21, 2022 22:19
@petervdonovan
Copy link
Collaborator

CI is failing due to #1311... just cross-referencing here in case anyone missed it.

Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly right to me. I just left minor comments.

test/TypeScript/src/Stop.lf Outdated Show resolved Hide resolved
test/TypeScript/src/federated/DistributedStop.lf Outdated Show resolved Hide resolved
test/TypeScript/src/federated/DistributedStop.lf Outdated Show resolved Hide resolved
@hokeun hokeun merged commit cf7d3a5 into lf-lang:master Aug 2, 2022
@lhstrh lhstrh changed the title Add federated tests in TypeScript using stop request in federated execution Tests in TypeScript for requesting stop in federated execution Jan 26, 2023
@petervdonovan petervdonovan added the refactoring Code quality enhancement label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants