Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ROS2 serialization tests #1012

Merged
merged 49 commits into from
Mar 12, 2022
Merged

Added ROS2 serialization tests #1012

merged 49 commits into from
Mar 12, 2022

Conversation

Soroosh129
Copy link
Contributor

This PR adds two tests for the built-in ROS 2 serialization support in the CCpp target (with federated execution).

Soroosh129 added 30 commits March 8, 2022 21:06
@Soroosh129
Added ROS2 serialization tests
3a83ef0
@Soroosh129
Comments only
3a284f0
@Soroosh129
Changed ROS2 tooling version
6869ffe
@Soroosh129
Removed extra dependencies
440d610
@Soroosh129
Added a skeleton for serialization tests
0cc96b9
@Soroosh129
Hack to run all serialization tests in a separate workflow
e0d90ce
@Soroosh129
Added runs-on
4f3cd59
@Soroosh129
Updated workflow a bit
5f0a0a1
@Soroosh129
Added back on
04633f3
@Soroosh129
More streamlining
6b71804
@Soroosh129
Removed serialization test from AbstractTest
f36a967
@Soroosh129
Removed ROS 2 as a dependency
a2fd905
@Soroosh129
Added back coreutils
44c042e
@Soroosh129
Enable universe
0f3ed1a
@Soroosh129
Remove line break
a05329d
@Soroosh129
Adding missing dependency in the ROS docker image
d325eb3
@Soroosh129
Trying ros:latest Docker image
c2d3157
@Soroosh129
Added apt-get update
0c07de0
@Soroosh129
Small adjustments
9806255
@Soroosh129
Added back source for ROS
f205b7d
@Soroosh129
Install rclcpp
2d5e584
@Soroosh129
No quotes
81b4654
@Soroosh129
Trying entrypoint
389d2f1
@Soroosh129
Modifying bashrc
1cbb89f
@Soroosh129
Another try
51092d0
@Soroosh129
Adding debug messages to see if env is set up properly
d3f5d3d
@Soroosh129
Directly source ROS
2551c58
@Soroosh129
Trying to see if multiple run is the culprit
37cf18d
@Soroosh129
Trying again
7fabf64
@Soroosh129
Trying again
a0b1f2d
@Soroosh129 Soroosh129 requested review from cmnrd and lhstrh March 9, 2022 10:39
@Soroosh129 Soroosh129 marked this pull request as ready for review March 9, 2022 10:40
@Soroosh129 Soroosh129 added this to the 0.1.0 milestone Mar 10, 2022
lhstrh
lhstrh reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments (which should be understood in the context of what's currently in master). Let's merge in master, resolve the conflicts, and then I'll make a final pass. Looking pretty good so far!

test/C/src/serialization/ROSBuiltInSerialization.lf Outdated Show resolved Hide resolved
test/C/src/serialization/ROSBuiltInSerialization.lf Show resolved Hide resolved
test/C/src/serialization/ROSBuiltInSerialization.lf Outdated Show resolved Hide resolved
test/C/src/serialization/ROSBuiltInSerialization.lf Outdated Show resolved Hide resolved
test/C/src/serialization/ROSBuiltInSerializationSharedPtr.lf Outdated Show resolved Hide resolved
org.lflang.tests/src/org/lflang/tests/serialization/SerializationTest.java Outdated Show resolved Hide resolved
org.lflang.tests/src/org/lflang/tests/serialization/SerializationTest.java Outdated Show resolved Hide resolved
@lhstrh lhstrh merged commit bdb4c55 into master Mar 12, 2022
@lhstrh lhstrh deleted the ros2-ccpp-tests branch March 12, 2022 01:58
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the testing label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@cmnrd cmnrd Awaiting requested review from cmnrd

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Soroosh129 @lhstrh @petervdonovan