Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glocaltokens to 0.6.3 #488

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Update glocaltokens to 0.6.3 #488

merged 3 commits into from
Mar 21, 2022

Conversation

jacobswe
Copy link
Contributor

@jacobswe jacobswe commented Mar 20, 2022

glocaltokens issued a new update at 0.6.3 to resolve conflicts with Homeassistant. This pull request bumps all build versions to 0.6.3 and allow for the integration to successfully load. Fixes #487

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 20, 2022
@KapJI
Copy link
Collaborator

KapJI commented Mar 20, 2022

Source of the truth which HA uses is manifest.json where the version is specified correctly. poetry.lock is basically only used for CI, although I agree that should keep it in sync.

Edit: It's weird that it's not able to find that version because it clearly exists: https://pypi.org/project/glocaltokens/#history

@jacobswe
Copy link
Contributor Author

Thanks, yeah I just grabbed anywhere I saw the wrong version listed and overrode it. There is a glocaltokens merged PR that discusses issues with library pinning. Regardless, I was able to HACS install my fork, so I suspect it's just checking the pyproject.toml which had the old version listed.

Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the spotting it!

As @KapJI has already said, I don't quite see how this might affect Home Assistant failing to install/locate glocaltokens package, but one thing that i recently discovered is that glocaltokens are not correctly build on HA wheels side. Opened an issue for that and we seems to have kicked the progress. Let's see what Frenk will be able to see regarding the issue with HA not locating glocatokens package wheels.

@leikoilja
Copy link
Owner

@KapJI and @jacobswe, do you guys think it's a good idea we just say min version of glocaltokens should be 0.6.3 for ha-google-home dependencies?
Plus, bumping min version of zeroconf also seems to help solving dependency issues

image

@KapJI KapJI merged commit 849edb6 into leikoilja:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when attempting to add integration
4 participants