Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving HomeAssistant dependency conflicts #219

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

leikoilja
Copy link
Owner

With some Frenk's help:

What we had:

[tool.poetry.dependencies]
python = "^3.8"
gpsoauth = "^1.0.0"
requests = "^2.25.1"
simplejson = "^3.17.2"
zeroconf = "^0.36.2"

# We want to keep grpcio similar to Home Assistant
# https://github.com/home-assistant/core/blob/9ce2e9e8f4e9afaefc4a66e788d503ebe817c327/homeassistant/package_constraints.txt
grpcio = "1.43.0"

Those are pretty hard pins for a library.

requests is limited from =>2.25.1 and <2.26.0, while Home Assistant requires 2.27.1
Zeroconf has similar issues: https://github.com/home-assistant/core/blob/dev/requirements_all.txt#L2536
grpcio is hard pinned, which a library should never do. Home Assistant side: https://github.com/home-assistant/core/blob/dev/homeassistant/package_constraints.txt#L48-L51

So, on the first quick pass, those are definitely conflicting dependencies (and they've always been). Newer Python pip versions have a new resolver that no longer allows for this. And blocks the installation of packages with conflicts.

@leikoilja leikoilja requested a review from KapJI February 24, 2022 13:34
@leikoilja leikoilja self-assigned this Feb 24, 2022
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 24, 2022
@leikoilja leikoilja added bug Something isn't working and removed dependencies Pull requests that update a dependency file labels Feb 24, 2022
Copy link
Collaborator

@KapJI KapJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leikoilja leikoilja merged commit 24abd39 into master Feb 24, 2022
@leikoilja leikoilja deleted the resolve-ha-dependency-conflicts branch February 24, 2022 14:04
@leikoilja
Copy link
Owner Author

Will release a new minor version as well as test the fix later tonight, unfortunately, I have to run now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with installing package glocaltokens==0.6.2 after upgrade to HA 2022.3.0b0
2 participants