Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document thumbnail order #1366

Merged
merged 3 commits into from
May 21, 2019
Merged

Update document thumbnail order #1366

merged 3 commits into from
May 21, 2019

Conversation

jayoshih
Copy link
Contributor

@jayoshih jayoshih commented May 14, 2019 •
edited
Loading

Description

Updates preset order (originally, document and thumbnail had the same order). learningequality/le-utils#58 is also part of the fix here

Issue Addressed (if applicable)

Addresses #1328

Steps to Test

  • Open a document (pdf)
  • See if preview defaults to the pdf

Checklist

  • Is the code clean and well-commented?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time

@jayoshih jayoshih added the changelog Needs to be added to the changelog (remove once added) label May 14, 2019
@jayoshih jayoshih requested a review from rtibbles May 14, 2019 21:42
@jayoshih jayoshih merged commit 4c8ffa4 into learningequality:develop May 21, 2019
@jayoshih jayoshih removed the changelog Needs to be added to the changelog (remove once added) label May 22, 2019
@jayoshih jayoshih deleted the preview-fix branch March 9, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayoshih @rtibbles