Channel page fixes #1364
Merged
Channel page fixes #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop -> Staging
…into channel-page-fixes
jayoshih
commented
May 15, 2019
| @@ -84,7 +84,7 @@ describe('channelEditor', () => { | |||
| let nameInput = wrapper.find('.channel-name'); | |||
| nameInput.element.value = newName; | |||
| nameInput.trigger('input'); | |||
| nameInput.trigger('blur'); | |||
| nameInput.trigger('change'); | |||
There was a problem hiding this comment.
This fixes the problem of pressing Enter on the editor as it fires before the submit function is emitted. It still keeps the event from firing super often still though as it will trigger once the user exits the textbox
jayoshih
commented
May 15, 2019
| @@ -4,6 +4,8 @@ import State from 'edit_channel/state'; | |||
|
|
|||
| import Models from 'edit_channel/models'; | |||
|
|
|||
| require('jquery-file-download'); | |||
There was a problem hiding this comment.
Fixes channel details exporting as this got removed by the linter originally
jayoshih
commented
May 15, 2019
| @@ -81,6 +83,7 @@ export function deleteChannel(context, channelID) { | |||
| new Models.ChannelModel(channel).save( | |||
| { deleted: true }, | |||
| { | |||
| patch: true, | |||
There was a problem hiding this comment.
This fixes channel deletion as we just want to change the 'deleted' field and nothing else
kollivier
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed (if applicable)
Fixes #1337
Fixes #1320
Fixes #1319
Before/After Screenshots (if applicable)
Insert images here
Steps to Test
Implementation Notes (optional)
At a high level, how did you implement this?
Briefly describe how this works
Does this introduce any tech-debt items?
List anything that will need to be addressed later
Checklist
Delete any items that don't apply
docslabel been added if this introduces a change that needs to be updated in the user docs?CHANGELOGlabel been added to this pull request? Items with this label will be added to the CHANGELOG at a later time