Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On channel details, channel name not getting set on ENTER #1337

Closed
jayoshih opened this issue Apr 25, 2019 · 0 comments · Fixed by #1364
Closed

On channel details, channel name not getting set on ENTER #1337

jayoshih opened this issue Apr 25, 2019 · 0 comments · Fixed by #1364
Assignees

Comments

@jayoshih
Copy link
Contributor

Summary

When you create a new channel and type in a name then press enter, you get an error (vue is waiting on blur event to happen before committing a name)

Category

Select one: BUG

Traceback or relevant snippet from browser console

raven.js:58 TypeError: Cannot set property 'name' of undefined
    at u.e.SET_CHANNEL_NAME (mutations.js:78)
    at vuex.esm.js:697
    at vuex.esm.js:389
    at Array.forEach (<anonymous>)
    at vuex.esm.js:388
    at u._withCommit (vuex.esm.js:495)
    at u.commit (vuex.esm.js:387)
    at u.commit (vuex.esm.js:335)
    at u.a.commit (vuex.esm.js:651)
    at s.n.(/channels/anonymous function) (https://develop.studio.learningequality.org/static/js/bundles/common-3001e197b2a22fff9194.js:7:8269)
    at blur (ChannelEditor.vue?834d:1)
    at Bt (vue.runtime.esm.js:1854)
    at HTMLInputElement.n (vue.runtime.esm.js:2179)
    at HTMLInputElement.Mi.r._wrapper (vue.runtime.esm.js:6911)
    at HTMLInputElement.d (raven.js:445)
    at Object.removeChild (vue.runtime.esm.js:5707)
    at u (vue.runtime.esm.js:5878)
    at n (vue.runtime.esm.js:5867)
    at x (vue.runtime.esm.js:6154)
    at w (vue.runtime.esm.js:6123)
    at vue.runtime.esm.js:6229
    at k (vue.runtime.esm.js:6313)
    at vue.runtime.esm.js:6187
    at k (vue.runtime.esm.js:6313)
    at Sn.__patch__ (vue.runtime.esm.js:6476)
    at Sn.t._update (vue.runtime.esm.js:3942)
    at Sn.mn.before (vue.runtime.esm.js:4060)
    at mn.get (vue.runtime.esm.js:4473)
    at mn.run (vue.runtime.esm.js:4548)
    at fn (vue.runtime.esm.js:4304)
    at Array.<anonymous> (vue.runtime.esm.js:1980)
    at Xt (vue.runtime.esm.js:1906)

How to reproduce

  1. Create a new channel
  2. Type something into the channel name
  3. Press Enter without clicking anywhere else
@jayoshih jayoshih self-assigned this May 13, 2019
@jayoshih jayoshih mentioned this issue May 14, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant