Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header nav fix #1178

Merged
merged 7 commits into from
Jan 17, 2019
Merged

Header nav fix #1178

merged 7 commits into from
Jan 17, 2019

Conversation

jayoshih
Copy link
Contributor

@jayoshih jayoshih commented Jan 15, 2019

Description

Fixed responsive problem with main navbar

Issue Addressed (if applicable)

#679

Before/After Screenshots (if applicable)

header

Steps to Test

  • Change screen size and see if header is properly resized
  • Click the settings button

Checklist

  • Is the code clean and well-commented?
  • Have the changes been added to the CHANGELOG?
  • Are all user-facing strings translated properly (if applicable)?

@jayoshih jayoshih requested a review from micahscopes January 15, 2019 22:16
Copy link
Contributor

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -20,103 +20,94 @@ body {

/* NAVIGATION BAR */
/* nav variables/mixins */

#top-navigation, #main-nav-right{
display: grid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's an extra indentation here

#top-navigation, #main-nav-right{
display: grid;
grid-auto-flow: column;
justify-content: space-between;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting! I hadn't considered this approach

@jayoshih
Copy link
Contributor Author

@micahscopes Pushing one more commit- this one fixes an issue with the channel dropdown styling where the channels weren't filling the dropdown space. Could you take a look at my last commit to see if it works for you?

image

@jayoshih jayoshih merged commit 4fb474d into learningequality:develop Jan 17, 2019
@jayoshih jayoshih deleted the header-nav-fix branch May 28, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants