Allow storage_class_name to be ""

According to the docs at https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class-1 - Fixes hashicorp#567 - Fixes hashicorp#102 - Fixes hashicorp#339
lawliet89 · Aug 13, 2019 · 0cfc18a · 0cfc18a
1 parent 822d092
commit 0cfc18a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/kubernetes/structure_persistent_volume_claim.go b/kubernetes/structure_persistent_volume_claim.go
@@ -4,8 +4,8 @@ import (
 	"errors"
 
 	"github.com/hashicorp/terraform/helper/schema"
-	"k8s.io/api/core/v1"
 	corev1 "k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"
 )
 
 // Flatteners
@@ -79,7 +79,7 @@ func expandPersistentVolumeClaimSpec(l []interface{}) (*v1.PersistentVolumeClaim
 	if v, ok := in["volume_name"].(string); ok {
 		obj.VolumeName = v
 	}
-	if v, ok := in["storage_class_name"].(string); ok && v != "" {
+	if v, ok := in["storage_class_name"].(string); ok {
 		obj.StorageClassName = ptrToString(v)
 	}
 	return obj, nil

diff --git a/kubernetes/structure_persistent_volume_spec.go b/kubernetes/structure_persistent_volume_spec.go
@@ -370,7 +370,7 @@ func flattenPersistentVolumeSpec(in v1.PersistentVolumeSpec) []interface{} {
 	if in.PersistentVolumeReclaimPolicy != "" {
 		att["persistent_volume_reclaim_policy"] = in.PersistentVolumeReclaimPolicy
 	}
-	if in.StorageClassName != "" {
+	if in.StorageClassName != nil {
 		att["storage_class_name"] = in.StorageClassName
 	}
 	if in.NodeAffinity != nil {