Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVC storage_class_name empty sets default storage class #567

Closed
davidschrooten opened this issue Jul 26, 2019 · 7 comments
Closed

PVC storage_class_name empty sets default storage class #567

davidschrooten opened this issue Jul 26, 2019 · 7 comments
Labels
acknowledged Issue has undergone initial review and is in our work queue. sdk-update-needed The current version of terraform-plugin-sdk does not support the required functionality

Comments

@davidschrooten
Copy link

davidschrooten commented Jul 26, 2019

Hello,

There is a critical bug for the kubernetes terraform provider that has been reported since 2017 but is still open.

See:
#102
#339

What happens is that terraform is not passing the empty storage class string instead somehow the pvc's are created with the default storage class. The work around mentioned by using label selectors is not working anymore on terraform 0.12.

Best regards,
David

@ajchiarello
Copy link

I was able to work around this by creating a dummy storage class that I applied to the PV and the PVC - not ideal, but it did work.

@davidschrooten
Copy link
Author

davidschrooten commented Jul 31, 2019

@ajchiarello good solution

lawliet89 added a commit to lawliet89/terraform-provider-kubernetes that referenced this issue Aug 13, 2019
@lawliet89
Copy link
Contributor

I opened #590 to fix this.

lawliet89 added a commit to lawliet89/terraform-provider-kubernetes that referenced this issue Aug 13, 2019
lawliet89 added a commit to lawliet89/terraform-provider-kubernetes that referenced this issue Aug 13, 2019
lawliet89 added a commit to lawliet89/terraform-provider-kubernetes that referenced this issue Dec 2, 2019
lawliet89 added a commit to lawliet89/terraform-provider-kubernetes that referenced this issue Dec 2, 2019
jgadling pushed a commit to chanzuckerberg/terraform-provider-kubernetes that referenced this issue Jan 2, 2020
jgadling pushed a commit to chanzuckerberg/terraform-provider-kubernetes that referenced this issue Jan 3, 2020
jgadling pushed a commit to chanzuckerberg/terraform-provider-kubernetes that referenced this issue Jan 3, 2020
@koxu1996
Copy link

koxu1996 commented Jan 5, 2020

Any updates on merging this? Bug is really annoying.

@leonbreedt
Copy link

+1, this is a blocker for using PVCs in our scenario, and we have to do volume mounts directly on the pod template spec, which does not allow us to override mount options, which breaks our scenario.

@aareet aareet added acknowledged Issue has undergone initial review and is in our work queue. sdk-update-needed The current version of terraform-plugin-sdk does not support the required functionality labels May 26, 2020
@dak1n1
Copy link
Contributor

dak1n1 commented Jun 3, 2020

Hi, we have a few issues relating to this that are being consolidated here: #872 See the new issue for a work-around. Thanks!

@dak1n1 dak1n1 closed this as completed Jun 3, 2020
@ghost
Copy link

ghost commented Jul 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acknowledged Issue has undergone initial review and is in our work queue. sdk-update-needed The current version of terraform-plugin-sdk does not support the required functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants