Remove asset manifest check and warning #1063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #729, removing the checks to determine at runtime if Telescope's assets are published and up to date.
The exception that is thrown if the assets appear to be missing doesn't play nicely with Vapor because it assumes that the assets should be present on the local filesystem at runtime, and the warning feels unnecessary too since for quite a long time now the docs have had very clear instructions about how to keep assets up to date automatically.
Closes #1062.
See also #594 and laravel/horizon#554, this warning wasn't immediately popular when it was added and both Telescope and Horizon now provide documentation that make it unnecessary.