Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Assets not published' exception thrown with default Vapor setup #1062

Closed
bakerkretzmar opened this issue May 19, 2021 · 1 comment · Fixed by #1063
Closed

'Assets not published' exception thrown with default Vapor setup #1062

bakerkretzmar opened this issue May 19, 2021 · 1 comment · Fixed by #1063

Comments

@bakerkretzmar
Copy link
Contributor

  • Telescope Version: 4.4.9
  • Laravel Version: 8.41.0
  • PHP Version: 8.0.3
  • Database Driver & Version: n/a

Description:

By default with a fresh Laravel app running on Vapor, it's not possible to view Telescope at all. The "Telescope assets are not published" exception is always thrown, because it checks public_path('vendor/telescope/mix-manifest.json') which doesn't exist on the lambda runner. Telescope can load its assets normally from S3/Cloudfront where Vapor uploads them, but it's impossible to get to that point because of the exception being thrown.

It is possible to work around this by adding php artisan telescope:publish to Vapor's build hooks and including all of Telescope's assets in the build artifact, but this adds about 1.5MB to the build and is redundant since the assets are also always uploaded to S3/Cloudfront.

Steps To Reproduce:

New Laravel app, install Telescope, deploy to Vapor, see the "Telescope assets are not published" exception if you try to view Telescope on Vapor.

@driesvints
Copy link
Member

I don't think this is really a Telescope issue but a Vapor issue. Let's see how your PR goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants