Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix issue with ArrayCache #48807

Closed
wants to merge 1 commit into from
Closed

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Oct 24, 2023

This one seems to have snuck into #48573 by accident.

@driesvints driesvints changed the title Fix issue with ArrayCache [10.x] Fix issue with ArrayCache Oct 24, 2023
@driesvints driesvints marked this pull request as draft October 24, 2023 11:36
@driesvints
Copy link
Member Author

@timacdonald the failing tests here tell me this was done deliberately probably?

@timacdonald
Copy link
Member

The existing behaviour is consistent with Redis^ and is how it should work.

If you cache something at 2000-01-01 00:00:05 with a TTL of an hour, it should expire at 2000-01-01 01:00:05.

^Redis does have a single millisecond error rate for expiration (https://redis.io/commands/expire/#expire-accuracy) which means keys may occasionally expire a millisecond after.

@driesvints driesvints closed this Oct 26, 2023
@driesvints driesvints deleted the fix-array-store-cache branch October 26, 2023 10:07
@driesvints
Copy link
Member Author

@timacdonald gotcha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants