-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Ensure array cache considers milliseconds #48573
[10.x] Ensure array cache considers milliseconds #48573
Conversation
/subcribe pr |
Tests seem to fail here @timacdonald |
Guys, I think we need to revert the changes from the PR and only then working on improvements. It seems to me that the ArrayCache functionality is not working quite correctly right now. I described the problem here: #48569 @taylorotwell Hello. What do you think about this? |
We've reverted the original PR for now |
- Locking laravel/framework (v10.25.2) @driesvints I confirm that all tests have begun to pass. Pipeline green. Thank you. |
c1c4d45
to
a84488e
Compare
a84488e
to
ecdd76f
Compare
I've rebased and included the original change here as well. |
@rez1dent3 I've tested this change against the testsuite passes. I repeated the suite 20 times and it passed everytime (it was flaky with the original fix but without this millisecond fix). |
@timacdonald Yes, this option works correctly. I checked it on my tests. |
With the recent fix to the array cache driver, #48497, it has surfaced another problem with it that was previously hidden by the initial issue.
The array cache driver, unlike the redis cache driver, does not take milliseconds into account.
This PR fixes that.
This is technically a breaking change with the return type changes, but one I think we should make as it is really a bugfix. The array driver should always have used milliseconds.
fixes #48569