[8.x] Add context recursively #37890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
commented
Jul 2, 2021
| $writer->error('foo', ['payload' => ['type' => 'cli']]); | ||
| } | ||
|
|
||
| public function testContextIsRemovedFromAllSubsequentLogs() |
There was a problem hiding this comment.
Also add a test for withoutContext.
|
See #37860 |
|
Ah such a pity @driesvints , 🤞 for 9.x then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pretty common practice to group pieces of context into a main data group when logging.
It makes it easier to manage filters when using a logging solution, like loggly, papertrail, etc...
At the moment adding context does not allow to do it in a recursive manner.
This PR introduces this possibility.