Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @chasenyc's recent log context PR: github.com//pull/37847
We have a custom context service to handle this in our own application, and I was glad to see it added to the framework. But I have a couple changes to propose based on our experience.
First, log context doesn't have to be flat. Say you want to have a couple values nested under user and then only change one. The following is how that would play out with
array_merge()
,array_merge_recursive()
, andarray_replace_recursive()
.So array_replace_recursive() is what we landed on, and is what I have included in this PR. The TL;DR on this is that you can now change an individual nested key in the log context.
Second, I added a
getContext()
to get what is currently in the Log context. If you pass in some local overriding context to this method it will not apply to the future logs, only the current method response. This is useful if you want to use your Log context for another purpose. For example, you could pass this context to a feature flag provider.