-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Added AP to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11151
Conversation
WalkthroughThe pull request adds a new antipattern to the Portuguese grammar rules in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)
4382-4382
: Consider adding more example casesWhile the current example is good, consider adding more examples to cover different variations of the word (coupé/cupê) and different preceding parts of speech (adjectives, nouns, numbers) to make the antipattern's coverage more explicit.
Example additions:
<example>O coupé esportivo está na garagem.</example> <example>Dois cupês vermelhos foram vendidos.</example>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
(1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)
4379-4383
: Well-structured antipattern for handling 'coupé' variations!The antipattern effectively handles various spellings of 'coupé' (coupé, coupê, cupé, cupê) while correctly considering number agreement with preceding adjectives, nouns, and numbers. The postag pattern
AQ..[PN].+|N..[PN].+|Z0.[PN].+
appropriately covers all relevant parts of speech that could precede these terms.
Just an antipattern.
Summary by CodeRabbit