fix: summary of duckduckgo_search #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoLey
pushed a commit
to XiaoLey/dify
that referenced
this pull request
Jun 22, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 24, 2024
* refs/heads/deploy/dev: (273 commits) chore: host required fix: monitor copywrite feat: make show citations enable default chore: use singular style in middleware config class name (#5502) refactor: extract hosted service configs into dify config (#5504) fix: summary of duckduckgo_search (#5488) fix: zhipu tool calling, this PR fixes the bug described in issue #5496 (#5469) fix: tongyi json output (#5396) fix: firecrawl apikey not start with fc- (#5498) fix lock refactor: extract db configs and celery configs into dify config (#5491) refactor: extract storage provider configs into dify configs (#5443) chore: use singular style in config class name (#5489) chore: remove pip support for api service (#5453) Add Oracle23ai as a vector datasource (#5342) build: support Poetry for depencencies tool in api's Dockerfile (#5105) feat: add ops trace encrypt_config decrypt_config obfuscate_config feat: add remove tracing app fix: max_tokens of qwen-plus & qwen-plus-chat (#5480) feat: add support for Vertex AI claude-3-5-sonnet@20240620 (#5475) ...
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 24, 2024
* refs/heads/main: (31 commits) feat: support predefined models for openrouter (#5494) chore: refactor the http executor node (#5212) chore: add create_json_message api for tools (#5440) fix(api/model_runtime/azure/llm): Switch to tool_call. (#5541) Fix: position of log modal (#5538) feat: Add program_name attribute to TiDB connection (#5499) add opensearch default value (#5536) feat: make Citations and Attributions display enable default (#5508) Fix: resolve issue with embedding model field visibility toggling on datasets page (#5451) Fix: custom disclaim (#5535) Chore: chat log refactor (#5523) feat: use root dir to start python and celery (#5515) feat: add new features to enhance image and link handling in Jina tool (#5517) fix: apply best practices for the latest buildkit (#5527) fix: added error handling for novita ai tool query (#5506) feat: add Asia/Ho_Chi_Minh timezone (#5521) fix: correct typos (#5510) chore: use singular style in middleware config class name (#5502) refactor: extract hosted service configs into dify config (#5504) fix: summary of duckduckgo_search (#5488) ... # Conflicts: # api/core/app/apps/advanced_chat/app_generator.py # api/poetry.lock # api/requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The origin summary method of BuildinTool is check how many token in the content, if the token < 60% of the llm's default max token, it won't work. It seems a support for large context content, But here I think a summary for the whole search result would be better.
Type of Change
How Has This Been Tested?
I test the tool node execute result locally.
Suggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes