fix: zhipu tool calling, this PR fixes the bug described in issue #5496 #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got unknown type role=<PromptMessageRole.TOOL: 'tool'> content='{"company_info": "[]", "register_info": "{\"company_info\": \"[]\"}"}' name='getCompanyInfo' tool_call_id='47e36eb3-a484-4eb9-955c-3122655d9143
reproduce environment:
1. select chat model to ZhiPu GLM-4 model
2. Create a agent app with a tool published by a workflow
3. Ask a question to the agent and it MUST invoke a tool for the question and the answer is feedbacked by the agent.
4. In the save conversation, then you ask the second question, the UI will pop an error message like 'Got unknown type role=<PromptMessageRole.TOOL: 'tool'> content='{"company_info": "[]", "register_info": "{\"company_info\": \"[]\"}"}' name='getCompanyInfo' tool_call_id='47e36eb3-a484-4eb9-955c-3122655d9143'
|
Thanks for your contribution, please open an issue first, then link it to this PR. It will be helpful for us to manage our community. 😇 |
I have updated the PR's title and description to link to an new issue #5496 |
laipz8200
approved these changes
Jun 22, 2024
XiaoLey
pushed a commit
to XiaoLey/dify
that referenced
this pull request
Jun 22, 2024
…ggenius#5496 (langgenius#5469) Co-authored-by: vccler <vccler@163.com> Co-authored-by: -LAN- <laipz8200@outlook.com>
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 24, 2024
* refs/heads/deploy/dev: (273 commits) chore: host required fix: monitor copywrite feat: make show citations enable default chore: use singular style in middleware config class name (#5502) refactor: extract hosted service configs into dify config (#5504) fix: summary of duckduckgo_search (#5488) fix: zhipu tool calling, this PR fixes the bug described in issue #5496 (#5469) fix: tongyi json output (#5396) fix: firecrawl apikey not start with fc- (#5498) fix lock refactor: extract db configs and celery configs into dify config (#5491) refactor: extract storage provider configs into dify configs (#5443) chore: use singular style in config class name (#5489) chore: remove pip support for api service (#5453) Add Oracle23ai as a vector datasource (#5342) build: support Poetry for depencencies tool in api's Dockerfile (#5105) feat: add ops trace encrypt_config decrypt_config obfuscate_config feat: add remove tracing app fix: max_tokens of qwen-plus & qwen-plus-chat (#5480) feat: add support for Vertex AI claude-3-5-sonnet@20240620 (#5475) ...
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Agent App with Zhipu GLM-4 Model and workflow tool always fails to get the response when asking the second question after the first tool calling is done.
reproduce steps:
Fixes #5496
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please follow with the reproduce steps