Make json output parser handle newlines inside markdown code blocks #8682
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fd46853 to
bb766f1
Compare
| return match.group(1) + value + match.group(3) | ||
|
|
||
|
|
||
| def custom_parser(multiline_string: str) -> str: |
There was a problem hiding this comment.
Do you mind marking these as private functions?
Could you add a bit more documentation to explain what it means to "handle new lines and other special characters" correctly (i.e., explaining that special characters need to be escape properly, so this is searching for instances of special characters that aren't being escaped inside the action input etc...)
There was a problem hiding this comment.
From a glance at the code it's hard to tell whether the parser is exhaustive or whether there are more scenarios that will not be handled properly
There was a problem hiding this comment.
@eyurtsev sure - updated.
There was a problem hiding this comment.
Re: exhaustivity - I'm not sure. There may be other scenarios but I'm not aware of them. The main thing I was running into was single escaped \n and unescaped " breaking JSON parsing.
|
thanks @bborn! |
Update to #8528
Newlines and other special characters within markdown code blocks returned as
action_inputshould be handled correctly (in particular, unescaped"=>\"and\n=>\\n) so they don't break JSON parsing.@baskaryan