Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #8357 by making json backtick regex greedy #8528

Conversation

bborn
Copy link
Contributor

@bborn bborn commented Jul 31, 2023

@baskaryan @hinthornw

…kdown codeblocks in json response should not break the parser
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 31, 2023 5:57pm
langchain-deprecated ⬜️ Ignored (Inspect) Jul 31, 2023 5:57pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 31, 2023
@baskaryan
Copy link
Collaborator

awesome, thanks @bborn!

@baskaryan baskaryan merged commit 5a490a7 into langchain-ai:master Jul 31, 2023
@schinto
Copy link

schinto commented Aug 3, 2023

Many thanks @bborn

baskaryan pushed a commit that referenced this pull request Aug 7, 2023
…8682)

Update to #8528

Newlines and other special characters within markdown code blocks
returned as `action_input` should be handled correctly (in particular,
unescaped `"` => `\"` and `\n` => `\\n`) so they don't break JSON
parsing.

@baskaryan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants