Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for repetition index to the full zip structural encoding #3335

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

westonpace
Copy link
Contributor

No description provided.

@westonpace
Copy link
Contributor Author

westonpace commented Jan 3, 2025

Leaving as draft until #3324 merges

@github-actions github-actions bot added the enhancement New feature or request label Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 81.98614% with 234 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (8fe7147) to head (8a1104c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/repdef.rs 79.60% 91 Missing and 3 partials ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 87.47% 57 Missing and 6 partials ⚠️
rust/lance-encoding/src/data.rs 13.51% 32 Missing ⚠️
rust/lance-encoding/src/encoder.rs 79.72% 14 Missing and 1 partial ⚠️
...ust/lance-encoding/src/encodings/physical/value.rs 0.00% 12 Missing ⚠️
rust/lance-encoding/src/buffer.rs 60.00% 8 Missing ⚠️
rust/lance-encoding/src/format.rs 0.00% 8 Missing ⚠️
...encoding/src/encodings/physical/fixed_size_list.rs 66.66% 1 Missing ⚠️
rust/lance-encoding/src/utils/bytepack.rs 99.32% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
+ Coverage   78.90%   78.91%   +0.01%     
==========================================
  Files         247      248       +1     
  Lines       88263    89275    +1012     
  Branches    88263    89275    +1012     
==========================================
+ Hits        69643    70455     +812     
- Misses      15729    15936     +207     
+ Partials     2891     2884       -7     
Flag Coverage Δ
unittests 78.91% <81.98%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace force-pushed the feat/full-zip-repetition-index branch from 9701195 to 8a1104c Compare January 4, 2025 15:14
@westonpace westonpace marked this pull request as ready for review January 7, 2025 15:09
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@westonpace westonpace merged commit fc74654 into lancedb:main Jan 7, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants