Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move fsl handling to structural encodings and add support for miniblock #3324

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

westonpace
Copy link
Contributor

Previously we had some support for FSL in the full zip encoder by treating FSL as a "compression". Implementing this the same way in miniblock was rather tricky and it seemed more correct to handle FSL at the structural layer.

Now the structural encoding flattens data and the compression layer just sees a larger array of items and is unaware of any FSL. We may need to revisit this decision in the future if we want to add a "vector compression" algorithm but, as none exists yet, we can worry about that later.

@github-actions github-actions bot added enhancement New feature or request python labels Jan 1, 2025
@westonpace
Copy link
Contributor Author

westonpace commented Jan 1, 2025

Leaving as draft until #3323 merges

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.58252% with 120 lines in your changes missing coverage. Please review.

Project coverage is 78.90%. Comparing base (38a0a92) to head (2da51fe).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/data.rs 15.78% 32 Missing ⚠️
rust/lance-datagen/src/generator.rs 0.00% 22 Missing ⚠️
rust/lance-encoding/src/encoder.rs 72.00% 13 Missing and 1 partial ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 94.52% 7 Missing and 5 partials ⚠️
...ust/lance-encoding/src/encodings/physical/value.rs 0.00% 12 Missing ⚠️
rust/lance-encoding/src/repdef.rs 95.56% 7 Missing and 2 partials ⚠️
rust/lance-encoding/src/format.rs 0.00% 8 Missing ⚠️
rust/lance-io/src/scheduler.rs 25.00% 6 Missing ⚠️
rust/lance-core/src/datatypes.rs 66.66% 2 Missing and 2 partials ⚠️
rust/lance-core/src/utils/path.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3324      +/-   ##
==========================================
- Coverage   78.97%   78.90%   -0.07%     
==========================================
  Files         246      246              
  Lines       87628    88144     +516     
  Branches    87628    88144     +516     
==========================================
+ Hits        69202    69552     +350     
- Misses      15558    15718     +160     
- Partials     2868     2874       +6     
Flag Coverage Δ
unittests 78.90% <80.58%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@westonpace westonpace merged commit a6aadaf into lancedb:main Jan 7, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants