Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove overzealous warning #3239

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: remove overzealous warning #3239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rust/lance-index/src/scalar/expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use futures::join;
use lance_core::{utils::mask::RowIdMask, Result};
use lance_datafusion::{expr::safe_coerce_scalar, planner::Planner};
use log::warn;

Check warning on line 19 in rust/lance-index/src/scalar/expression.rs

View workflow job for this annotation

GitHub Actions / linux-arm 

unused import: `log::warn`

Check warning on line 19 in rust/lance-index/src/scalar/expression.rs

View workflow job for this annotation

GitHub Actions / linux-arm 

unused import: `log::warn`

Check warning on line 19 in rust/lance-index/src/scalar/expression.rs

View workflow job for this annotation

GitHub Actions / linux-build (stable) 

unused import: `log::warn`

Check warning on line 19 in rust/lance-index/src/scalar/expression.rs

View workflow job for this annotation

GitHub Actions / linux-build (stable) 

unused import: `log::warn`

Check warning on line 19 in rust/lance-index/src/scalar/expression.rs

View workflow job for this annotation

GitHub Actions / linux-build (nightly) 

unused import: `log::warn`

Check warning on line 19 in rust/lance-index/src/scalar/expression.rs

View workflow job for this annotation

GitHub Actions / linux-build (nightly) 

unused import: `log::warn`
use tracing::instrument;

use super::{AnyQuery, LabelListQuery, SargableQuery, ScalarIndex};
Expand Down Expand Up @@ -567,7 +567,6 @@
} else {
// Datafusion's query simplifier will canonicalize expressions and so we shouldn't reach this case. If, for some reason, we
// do reach this case we can handle it in the future by inverting expr.op and swapping the left and right sides
warn!("Unexpected comparison encountered (DF simplifier should have removed this case). Scalar indices will not be applied");
None
}
}
Expand Down
Loading