Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove overzealous warning #3239

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

westonpace
Copy link
Contributor

In the code parsing scalar expressions I am expecting binary expressions to follow a certain pattern (column op scalar and not scalar op column) and so I added a warning when I didn't see the pattern since that would mean my assumption was wrong and then I returned None.

However, the pattern I was expecting was a bit stricter than that (indexed column op scalar) and there are lots of cases where we might see not indexed column op scalar and yet returning None is exactly the right thing to do here so we're ok and don't need the warning.

@github-actions github-actions bot added the bug Something isn't working label Dec 12, 2024
@westonpace westonpace merged commit 00d1e84 into lancedb:main Dec 12, 2024
24 of 26 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (7ec23f0) to head (a52ffee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
+ Coverage   78.48%   78.49%   +0.01%     
==========================================
  Files         245      245              
  Lines       84998    85032      +34     
  Branches    84998    85032      +34     
==========================================
+ Hits        66707    66744      +37     
- Misses      15473    15476       +3     
+ Partials     2818     2812       -6     
Flag Coverage Δ
unittests 78.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants