Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code parsing scalar expressions I am expecting binary expressions to follow a certain pattern (
column op scalar
and notscalar op column
) and so I added a warning when I didn't see the pattern since that would mean my assumption was wrong and then I returned None.However, the pattern I was expecting was a bit stricter than that (
indexed column op scalar
) and there are lots of cases where we might seenot indexed column op scalar
and yet returningNone
is exactly the right thing to do here so we're ok and don't need the warning.