Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): remove backport and checklist comment #12423

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 6, 2025

Motivation

pull_request_target is too hard to use correctly, we should have workflows that rely on it

Implementation information

Remove the backport workflow and the checklist PR comment.
We will find better ways to implement these that don't require pull_request_target

We will find better ways to implement these that
don't require `pull_request_target`

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner January 6, 2025 13:51
@lahabana lahabana requested review from jijiechen and Automaat January 6, 2025 13:51
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Jan 6, 2025
@lahabana lahabana enabled auto-merge (squash) January 6, 2025 15:16
.github/workflows/check.yaml Outdated Show resolved Hide resolved
@lahabana lahabana disabled auto-merge January 6, 2025 15:38
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana enabled auto-merge (squash) January 6, 2025 15:39
@lahabana lahabana merged commit 1b08066 into kumahq:master Jan 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants