-
Notifications
You must be signed in to change notification settings - Fork 337
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci(github): remove backport and checklist comment (#12423)
## Motivation `pull_request_target` is too hard to use correctly, we should have workflows that rely on it ## Implementation information Remove the backport workflow and the checklist PR comment. We will find better ways to implement these that don't require `pull_request_target` --------- Signed-off-by: Charly Molter <charly.molter@konghq.com>
- Loading branch information
Showing
3 changed files
with
53 additions
and
39 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| on: | ||
| schedule: | ||
| - cron: '*/5 * * * *' #every 5mins | ||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| find-prs: | ||
| runs-on: ubuntu-24.04 | ||
| outputs: | ||
| recent_prs: ${{ steps.get-recent-prs.outputs.out }} | ||
| active_branches: ${{ steps.active-branches.outputs.out }} | ||
| steps: | ||
| - id: active-branches | ||
| run: | | ||
| echo "out=$(gh api /repos/${{ github.repository }}/contents/active-branches.json --jq '.content | @base64d')" >> $GITHUB_OUTPUT | ||
| - id: get-recent-prs | ||
| run: | | ||
| prs=$(gh pr list --json number,title,url --search "updated:>=$(date --date='10 minutes ago' +'%Y-%m-%dT%H:%M:%S%z') -author:app/github-actions -author:dependabot") | ||
| echo "out=$prs" >> $GITHUB_OUTPUT | ||
| pr-comment: | ||
| needs: find-prs | ||
| runs-on: ubuntu-24.04 | ||
| strategy: | ||
| matrix: ${{ fromJson(needs.get-prs.outputs.recent_prs) }} | ||
| max-parallel: 1 # to avoid using too many runners | ||
| steps: | ||
| - uses: marocchino/sticky-pull-request-comment@daa4a82a0a3f6c162c02b83fa44b3ab83946f7cb # v2.9.0 | ||
| with: | ||
| header: PR reviewer checklist | ||
| only_create: true | ||
| number: ${{ matrix.number }} | ||
| message: | | ||
| ## Reviewer Checklist | ||
| :mag: Each of these sections need to be checked by the reviewer of the PR :mag:: | ||
| If something doesn't apply please check the box and add a justification if the reason is non obvious. | ||
| - [ ] Is the PR title satisfactory? Is this part of a larger feature and should be grouped using `> Changelog`? | ||
| - [ ] PR description is clear and complete. It [Links to relevant issue][1] as well as docs and UI issues | ||
| - [ ] This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry) | ||
| - [ ] IPv6 is taken into account (.e.g: no string concatenation of host port) | ||
| - [ ] Tests (Unit test, E2E tests, manual test on universal and k8s) | ||
| - Don't forget `ci/` labels to run additional/fewer tests | ||
| - [ ] Does this contain a change that needs to be notified to users? In this case, [`UPGRADE.md`](../blob/master/UPGRADE.md) should be updated. | ||
| - [ ] Does it need to be backported according to the [backporting policy](../blob/master/CONTRIBUTING.md#backporting)? ([this](https://github.com/kumahq/kuma/actions/workflows/auto-backport.yaml) GH action will add "backport" label based on these [file globs](https://github.com/kumahq/kuma/blob/master/.github/workflows/auto-backport.yaml#L6), if you want to prevent it from adding the "backport" label use [no-backport-autolabel](https://github.com/kumahq/kuma/blob/master/.github/workflows/auto-backport.yaml#L8) label) | ||
| [1]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword | ||
| maybe-backport: | ||
| needs: find-prs | ||
| runs-on: ubuntu-24.04 | ||
| strategy: | ||
| matrix: ${{ fromJson(needs.get-prs.outputs.prs_to_backport) }} | ||
| max-parallel: 1 # to avoid using too many runners |