Chore performance improvements tech debt 1 #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…improvements-tech-debt-1
…improvements-tech-debt-1
jorgeepc
approved these changes
Feb 8, 2024
| @@ -9,7 +9,7 @@ import useSelectAsCurrent from '../../../hooks/useSelectAsCurrent'; | |||
|
|
|||
| interface IProps extends NodeProps<INodeDataSpan> {} | |||
|
|
|||
| const TestSpanNode = ({data, id, selected}: IProps) => { | |||
| const TestSpanNode = ({data, id, selected, ...props}: IProps) => { | |||
| return DAGService.getEdgesAndNodes(nodesDatum); | ||
| } | ||
|
|
||
| export const getShouldShowDAG = (spanCount: number): boolean => spanCount <= 200; |
There was a problem hiding this comment.
Should we use the constant here?
| @@ -87,3 +87,12 @@ export const getParsedURL = (rawUrl: string): URL => { | |||
|
|
|||
| return new URL(rawUrl); | |||
| }; | |||
|
|
|||
| export const withLowPriority = | |||
xoscar
added a commit
that referenced
this pull request
Feb 13, 2024
* chore(frontend): indentifying performance improvements * chore(frontend): identify performance improvements * feat(frontend): hide dag view for big traces (#3606) * Chore performance improvements tech debt 1 (#3607) * adding async functionality * chore(frontend): DAG improvements * chore(frontend): DAG improvements * chore(frontend): fixing spinner styles * chore(frontend): fixing spinner styles * feat(frontend): fixing tests * chore(frontend): fixing spinner styles * chore(frontend): FE Improvements for the Test View (#3613) * adding async functionality * chore(frontend): DAG improvements * chore(frontend): DAG improvements * chore(frontend): fixing spinner styles * chore(frontend): fixing spinner styles * feat(frontend): fixing tests * chore(frontend): fixing spinner styles * chore(frontend): FE Improvements for the Test View * chore(frontend): reverting editor changes * chore(frontend): Adding memoization for useComplete hook * chore(frontend): Adding Search Service usage * chore(frontend): cleanup * feat(frontend): implement virtual list for timeline view (#3617) * feat(frontend): implement virtual list for timeline view * remove prop * add header and collapse * feat: add timeline view connectors (#3623) * feat(frontend): Implemeting new Timeline for the Test Page (#3627) * feat(frontend): Implemeting new Timeline for the Test Page * feat(frontend): Fixing tests * feat(frontend): Fixing tests * Chore performance improvements span search (#3629) * feat(frontend): Implemeting new Timeline for the Test Page * feat(frontend): Implementing span search for analyzer and test views * feat(frontend): read improvements * feat(frontend): adding single line input component * feat(frontend): updating analyzer styles * feat(frontend): Fixing tests * feat(frontend): Fixing tests --------- Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Feb 13, 2024
* start dashboard if agent mode is set as dashboard * update environment and collector statistics * feat: update list of tests based on test runs received by the agent * update test run counter * make dashboard as part of the desktop option list * open test run in browser * fix panic * make it possible to exit and go back to dashboard * remove dashboard mode from CLI * Chore performance improvements (#3616) * chore(frontend): indentifying performance improvements * chore(frontend): identify performance improvements * feat(frontend): hide dag view for big traces (#3606) * Chore performance improvements tech debt 1 (#3607) * adding async functionality * chore(frontend): DAG improvements * chore(frontend): DAG improvements * chore(frontend): fixing spinner styles * chore(frontend): fixing spinner styles * feat(frontend): fixing tests * chore(frontend): fixing spinner styles * chore(frontend): FE Improvements for the Test View (#3613) * adding async functionality * chore(frontend): DAG improvements * chore(frontend): DAG improvements * chore(frontend): fixing spinner styles * chore(frontend): fixing spinner styles * feat(frontend): fixing tests * chore(frontend): fixing spinner styles * chore(frontend): FE Improvements for the Test View * chore(frontend): reverting editor changes * chore(frontend): Adding memoization for useComplete hook * chore(frontend): Adding Search Service usage * chore(frontend): cleanup * feat(frontend): implement virtual list for timeline view (#3617) * feat(frontend): implement virtual list for timeline view * remove prop * add header and collapse * feat: add timeline view connectors (#3623) * feat(frontend): Implemeting new Timeline for the Test Page (#3627) * feat(frontend): Implemeting new Timeline for the Test Page * feat(frontend): Fixing tests * feat(frontend): Fixing tests * Chore performance improvements span search (#3629) * feat(frontend): Implemeting new Timeline for the Test Page * feat(frontend): Implementing span search for analyzer and test views * feat(frontend): read improvements * feat(frontend): adding single line input component * feat(frontend): updating analyzer styles * feat(frontend): Fixing tests * feat(frontend): Fixing tests --------- Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com> * disable logger in dashboard mode * keep old log level * add comment about why we are disabling logs in dashboard mode --------- Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Feb 13, 2024
* feat: agent dashboard header layout (#3592) * add initial dashboard code * implement banner for messages in header * commit rest of files * fix build and set logo static * feat: agent UI test run list (#3619) * adapt layout to match @olha23's design * add test run list * docs: comment some layout explanation * feat: agent dashboard start (#3631) * start dashboard if agent mode is set as dashboard * update environment and collector statistics * feat: update list of tests based on test runs received by the agent * update test run counter * make dashboard as part of the desktop option list * open test run in browser * fix panic * make it possible to exit and go back to dashboard * remove dashboard mode from CLI * Chore performance improvements (#3616) * chore(frontend): indentifying performance improvements * chore(frontend): identify performance improvements * feat(frontend): hide dag view for big traces (#3606) * Chore performance improvements tech debt 1 (#3607) * adding async functionality * chore(frontend): DAG improvements * chore(frontend): DAG improvements * chore(frontend): fixing spinner styles * chore(frontend): fixing spinner styles * feat(frontend): fixing tests * chore(frontend): fixing spinner styles * chore(frontend): FE Improvements for the Test View (#3613) * adding async functionality * chore(frontend): DAG improvements * chore(frontend): DAG improvements * chore(frontend): fixing spinner styles * chore(frontend): fixing spinner styles * feat(frontend): fixing tests * chore(frontend): fixing spinner styles * chore(frontend): FE Improvements for the Test View * chore(frontend): reverting editor changes * chore(frontend): Adding memoization for useComplete hook * chore(frontend): Adding Search Service usage * chore(frontend): cleanup * feat(frontend): implement virtual list for timeline view (#3617) * feat(frontend): implement virtual list for timeline view * remove prop * add header and collapse * feat: add timeline view connectors (#3623) * feat(frontend): Implemeting new Timeline for the Test Page (#3627) * feat(frontend): Implemeting new Timeline for the Test Page * feat(frontend): Fixing tests * feat(frontend): Fixing tests * Chore performance improvements span search (#3629) * feat(frontend): Implemeting new Timeline for the Test Page * feat(frontend): Implementing span search for analyzer and test views * feat(frontend): read improvements * feat(frontend): adding single line input component * feat(frontend): updating analyzer styles * feat(frontend): Fixing tests * feat(frontend): Fixing tests --------- Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com> * disable logger in dashboard mode * keep old log level * add comment about why we are disabling logs in dashboard mode --------- Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com> --------- Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several of the todos for the trace view, it also improves the way we are rendering the DAG in case a big list of spans are in display.
Changes
Fixes
Checklist