Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): hide dag view for big traces #3606

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Feb 6, 2024

This PR hides the DAG view for traces that are over the limit of spans.

Changes

  • hide DAG view

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2024-02-06 at 17 21 07

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 10:03pm

@jorgeepc jorgeepc self-assigned this Feb 6, 2024
@jorgeepc jorgeepc changed the title Feat hide dag view feat(frontend): hide dag view for big traces Feb 6, 2024
@jorgeepc jorgeepc marked this pull request as ready for review February 6, 2024 22:20
@xoscar xoscar merged commit d713747 into chore-performance-improvements Feb 8, 2024
39 checks passed
@xoscar xoscar deleted the feat-hide-dag-view branch February 8, 2024 15:21
xoscar added a commit that referenced this pull request Feb 13, 2024
* chore(frontend): indentifying performance improvements

* chore(frontend): identify performance improvements

* feat(frontend): hide dag view for big traces (#3606)

* Chore performance improvements tech debt 1 (#3607)

* adding async functionality

* chore(frontend): DAG improvements

* chore(frontend): DAG improvements

* chore(frontend): fixing spinner styles

* chore(frontend): fixing spinner styles

* feat(frontend): fixing tests

* chore(frontend): fixing spinner styles

* chore(frontend): FE Improvements for the Test View (#3613)

* adding async functionality

* chore(frontend): DAG improvements

* chore(frontend): DAG improvements

* chore(frontend): fixing spinner styles

* chore(frontend): fixing spinner styles

* feat(frontend): fixing tests

* chore(frontend): fixing spinner styles

* chore(frontend): FE Improvements for the Test View

* chore(frontend): reverting editor changes

* chore(frontend): Adding memoization for useComplete hook

* chore(frontend): Adding Search Service usage

* chore(frontend): cleanup

* feat(frontend): implement virtual list for timeline view (#3617)

* feat(frontend): implement virtual list for timeline view

* remove prop

* add header and collapse

* feat: add timeline view connectors (#3623)

* feat(frontend): Implemeting new Timeline for the Test Page (#3627)

* feat(frontend): Implemeting new Timeline for the Test Page

* feat(frontend): Fixing tests

* feat(frontend): Fixing tests

* Chore performance improvements span search (#3629)

* feat(frontend): Implemeting new Timeline for the Test Page

* feat(frontend): Implementing span search for analyzer and test views

* feat(frontend): read improvements

* feat(frontend): adding single line input component

* feat(frontend): updating analyzer styles

* feat(frontend): Fixing tests

* feat(frontend): Fixing tests

---------

Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
mathnogueira added a commit that referenced this pull request Feb 13, 2024
* start dashboard if agent mode is set as dashboard

* update environment and collector statistics

* feat: update list of tests based on test runs received by the agent

* update test run counter

* make dashboard as part of the desktop option list

* open test run in browser

* fix panic

* make it possible to exit and go back to dashboard

* remove dashboard mode from CLI

* Chore performance improvements (#3616)

* chore(frontend): indentifying performance improvements

* chore(frontend): identify performance improvements

* feat(frontend): hide dag view for big traces (#3606)

* Chore performance improvements tech debt 1 (#3607)

* adding async functionality

* chore(frontend): DAG improvements

* chore(frontend): DAG improvements

* chore(frontend): fixing spinner styles

* chore(frontend): fixing spinner styles

* feat(frontend): fixing tests

* chore(frontend): fixing spinner styles

* chore(frontend): FE Improvements for the Test View (#3613)

* adding async functionality

* chore(frontend): DAG improvements

* chore(frontend): DAG improvements

* chore(frontend): fixing spinner styles

* chore(frontend): fixing spinner styles

* feat(frontend): fixing tests

* chore(frontend): fixing spinner styles

* chore(frontend): FE Improvements for the Test View

* chore(frontend): reverting editor changes

* chore(frontend): Adding memoization for useComplete hook

* chore(frontend): Adding Search Service usage

* chore(frontend): cleanup

* feat(frontend): implement virtual list for timeline view (#3617)

* feat(frontend): implement virtual list for timeline view

* remove prop

* add header and collapse

* feat: add timeline view connectors (#3623)

* feat(frontend): Implemeting new Timeline for the Test Page (#3627)

* feat(frontend): Implemeting new Timeline for the Test Page

* feat(frontend): Fixing tests

* feat(frontend): Fixing tests

* Chore performance improvements span search (#3629)

* feat(frontend): Implemeting new Timeline for the Test Page

* feat(frontend): Implementing span search for analyzer and test views

* feat(frontend): read improvements

* feat(frontend): adding single line input component

* feat(frontend): updating analyzer styles

* feat(frontend): Fixing tests

* feat(frontend): Fixing tests

---------

Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>

* disable logger in dashboard mode

* keep old log level

* add comment about why we are disabling logs in dashboard mode

---------

Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com>
Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
mathnogueira added a commit that referenced this pull request Feb 13, 2024
* feat: agent dashboard header layout (#3592)

* add initial dashboard code

* implement banner for messages in header

* commit rest of files

* fix build and set logo static

* feat: agent UI test run list (#3619)

* adapt layout to match @olha23's design

* add test run list

* docs: comment some layout explanation

* feat: agent dashboard start (#3631)

* start dashboard if agent mode is set as dashboard

* update environment and collector statistics

* feat: update list of tests based on test runs received by the agent

* update test run counter

* make dashboard as part of the desktop option list

* open test run in browser

* fix panic

* make it possible to exit and go back to dashboard

* remove dashboard mode from CLI

* Chore performance improvements (#3616)

* chore(frontend): indentifying performance improvements

* chore(frontend): identify performance improvements

* feat(frontend): hide dag view for big traces (#3606)

* Chore performance improvements tech debt 1 (#3607)

* adding async functionality

* chore(frontend): DAG improvements

* chore(frontend): DAG improvements

* chore(frontend): fixing spinner styles

* chore(frontend): fixing spinner styles

* feat(frontend): fixing tests

* chore(frontend): fixing spinner styles

* chore(frontend): FE Improvements for the Test View (#3613)

* adding async functionality

* chore(frontend): DAG improvements

* chore(frontend): DAG improvements

* chore(frontend): fixing spinner styles

* chore(frontend): fixing spinner styles

* feat(frontend): fixing tests

* chore(frontend): fixing spinner styles

* chore(frontend): FE Improvements for the Test View

* chore(frontend): reverting editor changes

* chore(frontend): Adding memoization for useComplete hook

* chore(frontend): Adding Search Service usage

* chore(frontend): cleanup

* feat(frontend): implement virtual list for timeline view (#3617)

* feat(frontend): implement virtual list for timeline view

* remove prop

* add header and collapse

* feat: add timeline view connectors (#3623)

* feat(frontend): Implemeting new Timeline for the Test Page (#3627)

* feat(frontend): Implemeting new Timeline for the Test Page

* feat(frontend): Fixing tests

* feat(frontend): Fixing tests

* Chore performance improvements span search (#3629)

* feat(frontend): Implemeting new Timeline for the Test Page

* feat(frontend): Implementing span search for analyzer and test views

* feat(frontend): read improvements

* feat(frontend): adding single line input component

* feat(frontend): updating analyzer styles

* feat(frontend): Fixing tests

* feat(frontend): Fixing tests

---------

Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>

* disable logger in dashboard mode

* keep old log level

* add comment about why we are disabling logs in dashboard mode

---------

Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com>
Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>

---------

Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com>
Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants