-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket logs endpoint for polling envoy fleet container logs #80
Websocket logs endpoint for polling envoy fleet container logs #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is a draft but It is looking good to be packaged.
Wrap up the docker file and add it to https://github.com/kubeshop/kuskgateway-api-server/blob/main/kgw-api.yaml and we are good to go
upgrade websocket later after everything has been processed so we can return an http error if we need to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
Ready to be shipped
content: | ||
application/json: | ||
schema: | ||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change the type to an array of string? because it generates a wrong type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's it
? Are you using a library on the front end to generate stuff?
Changes
when starting websocket process you can specify the following options
when a request for envoy fleet logs comes in, a container log stream for the envoy container in the requested envoy fleet deployment is fetched from the api and the new logs that are sent over the stream are then sent over the websocket.