Feature: Expose Devportal #969
Conversation
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
✅ Deploy Preview for kusk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
internal/controllers/parser.go
Outdated
| //add devportal cluster | ||
| hostPortPair, err := getUpstreamHost(&options.UpstreamOptions{ | ||
| Service: &options.UpstreamService{ | ||
| Name: "kusk-gateway-devportal", |
There was a problem hiding this comment.
We should get this from some config somewhere instead of hard coding it
|
I can't approve this through GH since it was me who opened this PR. |
|
I tested the setup with images i built from this PR it resulted in having this nice presentation For testing you can use this diff |
| reportError(err) | ||
| return err | ||
| } | ||
| devPortalSpinner.Success("Installing Kusk Developer Portal") |
| } | ||
|
|
||
| kuskDevportalSpinner := utils.NewSpinner("Upgrading Kusk Devportal...") | ||
| if err := applyf(filepath.Join(dir, manifests_dir, "devportal.yaml")); err != nil { |
There was a problem hiding this comment.
Minor point but devportal.yaml is repeated.
| - containerPort: 80 | ||
| name: http | ||
| protocol: TCP | ||
| resources: |
There was a problem hiding this comment.
Are these strictly necessary? resources limits, that is.
There was a problem hiding this comment.
For us, not really
but for a user who will install this, it's being a good citizen as it were in kubernetes
Signed-off-by: jasmingacic jasmin.gacic@gmail.com
This PR addresses definition of DevPortal specs for backend as described here #654
closes #654
Changes