Handle multiple fleets #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobegor
approved these changes
Dec 28, 2021
Tarick
added a commit
that referenced
this pull request
Jan 5, 2022
* Adds the ability to handle deployments to the multiple Envoy fleets using an optional field "fleet" in the API and StaticRoute specs with name and namespace of the deployed EnvoyFleet using mutating webhooks. * In order for the webhooks to query K8s they were reworked to include client.Client from the kubebuilder supplied configuration to controller-runtime lower level handler. * Fixed latest refactoring vhost/domain handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Adds the ability to handle deployments to the multiple Envoy fleets using an optional field "fleet" in the API and StaticRoute specs with name and namespace of the deployed EnvoyFleet using mutating webhooks.
If the field is missing, cluster detection will set it to the deployed fleet. If there are multiple fleets in the cluster or no fleets at all, mutating webhooks will fail with the message to the user to set the fleet.
In order for the webhooks to query K8s they were reworked to include client.Client from the kubebuilder supplied configuration to controller-runtime lower level handler (will help with #95 as well).
The Helm chart and the documentation will be updated in #144.
Fixes
Fixes #149
Also introduced fixes to the vhosts configuration after the last refactoring.
Checklist