Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission webhook validation for multiple configs #95

Closed
Tarick opened this issue Nov 12, 2021 · 1 comment
Closed

Admission webhook validation for multiple configs #95

Tarick opened this issue Nov 12, 2021 · 1 comment
Labels

Comments

@Tarick
Copy link
Contributor

Tarick commented Nov 12, 2021

When we supply crd (either StaticRoute or API) we need to validate new config against already present ones in case conflicting routes exist.
This means to get all configs in the cluster, create Envoy config from them and then apply new CRD config and check for errors.
The problem here is that Admission webhook implementation can't get client.Client to access Kubernetes, so we need to inject that somehow.

@Tarick Tarick added the bug label Nov 12, 2021
@Tarick Tarick added this to the 0.0.1 milestone Nov 12, 2021
@Tarick Tarick mentioned this issue Dec 24, 2021
4 tasks
@olensmar olensmar removed this from the 0.0.1 milestone Mar 23, 2022
@aabedraba
Copy link

This is already a supported feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants