Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest instead of latest-fast for gce conformance #31486

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

upodroid
Copy link
Member

When krel builds latest-fast.txt, it puts the marker in the wrong place. kubernetes/release#3403

For now, i'm using latest.txt to mitigate this.

kubetest2 assumes the following:

 mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  $  curl https://storage.googleapis.com/k8s-release-dev/ci/latest.txt && echo
v1.30.0-alpha.0.341+d647d19f6aef81
 mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  $  curl https://storage.googleapis.com/k8s-release-dev/ci/v1.30.0-alpha.0.341+d647d19f6aef81/kubernetes.tar.gz -I
HTTP/2 200
x-guploader-uploadid: ABPtcPoVoPSTrHrPjRjoemgJc8HLW6F8kRZl6q_Qq-Ch937Ipzl3ySzt2O-itW-Hq0Bb0iZ3JSi9uNS9lw
expires: Tue, 19 Dec 2023 18:29:20 GMT
date: Tue, 19 Dec 2023 17:29:20 GMT
cache-control: public, max-age=3600
last-modified: Tue, 19 Dec 2023 17:15:35 GMT
etag: "f88cb622056e230835757a3d1cdaba86"
x-goog-generation: 1703006135769937
x-goog-metageneration: 1
x-goog-stored-content-encoding: identity
x-goog-stored-content-length: 518382
x-goog-meta-goog-reserved-file-mtime: 1703005200
content-type: application/x-tar
x-goog-hash: crc32c=7Agftg==
x-goog-hash: md5=+Iy2IgVuIwg1dXo9HNq6hg==
x-goog-expiration: Mon, 18 Mar 2024 17:15:35 GMT
x-goog-storage-class: STANDARD
accept-ranges: bytes
content-length: 518382
server: UploadServer
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

which breaks because when krel does a fast build, it stores it at https://storage.googleapis.com/k8s-release-dev/ci/fast/v1.30.0-alpha.0.341+d647d19f6aef81/kubernetes.tar.gz

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2023
@upodroid
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims December 19, 2023 17:30
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 19, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-unit-test-race-detector-nonblocking 20c0df1 link false /test pull-test-infra-unit-test-race-detector-nonblocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member

dims commented Dec 19, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit c80a28e into kubernetes:master Dec 19, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gce-conformance.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gce-conformance.yaml

In response to this:

When krel builds latest-fast.txt, it puts the marker in the wrong place. kubernetes/release#3403

For now, i'm using latest.txt to mitigate this.

kubetest2 assumes the following:

mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  $  curl https://storage.googleapis.com/k8s-release-dev/ci/latest.txt && echo
v1.30.0-alpha.0.341+d647d19f6aef81
mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  $  curl https://storage.googleapis.com/k8s-release-dev/ci/v1.30.0-alpha.0.341+d647d19f6aef81/kubernetes.tar.gz -I
HTTP/2 200
x-guploader-uploadid: ABPtcPoVoPSTrHrPjRjoemgJc8HLW6F8kRZl6q_Qq-Ch937Ipzl3ySzt2O-itW-Hq0Bb0iZ3JSi9uNS9lw
expires: Tue, 19 Dec 2023 18:29:20 GMT
date: Tue, 19 Dec 2023 17:29:20 GMT
cache-control: public, max-age=3600
last-modified: Tue, 19 Dec 2023 17:15:35 GMT
etag: "f88cb622056e230835757a3d1cdaba86"
x-goog-generation: 1703006135769937
x-goog-metageneration: 1
x-goog-stored-content-encoding: identity
x-goog-stored-content-length: 518382
x-goog-meta-goog-reserved-file-mtime: 1703005200
content-type: application/x-tar
x-goog-hash: crc32c=7Agftg==
x-goog-hash: md5=+Iy2IgVuIwg1dXo9HNq6hg==
x-goog-expiration: Mon, 18 Mar 2024 17:15:35 GMT
x-goog-storage-class: STANDARD
accept-ranges: bytes
content-length: 518382
server: UploadServer
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

which breaks because when krel does a fast build, it stores it at https://storage.googleapis.com/k8s-release-dev/ci/fast/v1.30.0-alpha.0.341+d647d19f6aef81/kubernetes.tar.gz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants