Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish the marker inside the fast folder #291

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Publish the marker inside the fast folder #291

merged 1 commit into from
Dec 20, 2023

Conversation

upodroid
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fast builds store the marker in gs://k8s-release-dev/ci/latest-fast.txt instead of gs://k8s-release-dev/ci/fast/latest-fast.txt which is problematic. Look at kubernetes/test-infra#31486 for specific details

Which issue(s) this PR fixes:

Part of kubernetes/release#3403

Special notes for your reviewer:

Does this PR introduce a user-facing change?

breaking change: fast marker (latest-fast.txt) is now stored inside the fast folder instead of the gcsRoot folder(ci)

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 19, 2023
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit e707968 into kubernetes-sigs:main Dec 20, 2023
@upodroid upodroid deleted the fast-marker-patch branch December 20, 2023 07:56
@upodroid upodroid mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cici37 cici37 Awaiting requested review from cici37

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upodroid @k8s-ci-robot @saschagrunert